Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding QEM schema directory #2597

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

adding QEM schema directory #2597

wants to merge 8 commits into from
+179 −0

Conversation

ecarlander
Copy link
Contributor

Description

Resolves issue #2586
Added directory mitiq/schema containing @ruheenirodi and I's current work developing QEM schema.

A lot of this work (all) is not finalized, so let us know if we should instead just start with an empty directory and only add work that is fully-developed.

License

  • I license this contribution under the terms of the GNU GPL, version 3 and grant Unitary Fund the right to provide additional permissions as described in section 7 of the GNU GPL, version 3.

Before opening the PR, please ensure you have completed the following where appropriate.

@codecov Codecov
Copy link

codecov bot commented Dec 7, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.73%. Comparing base (da77ec0) to head (c20156f).
Report is 8 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2597   +/-   ##
=======================================
  Coverage   98.73%   98.73%           
=======================================
  Files          92       92           
  Lines        4174     4183    +9     
=======================================
+ Hits         4121     4130    +9     
  Misses         53       53

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@natestemen natestemen self-requested a review December 7, 2024 02:40
@natestemen natestemen linked an issue Dec 7, 2024 that may be closed by this pull request
add QEM schema to repo #2586
Open
@natestemen
Copy link
Member

Thanks for adding this here Ella! Good start. We'll need to pair this down quite a bit before merging it in. For the time being, lets just add the schemas, and the code to validate experiments for the techniques you've already completed. Then we can make sure to add tests, ensure the code is formatted correctly, etc. Baby steps help us build up confidence about new code!

@cosenal
Copy link
Contributor

cosenal commented Jan 17, 2025

Is this in progress, is it in review? @natestemen Has the pair programming session happened? I see the PR is now much more manageable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natestemen natestemen Awaiting requested review from natestemen

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add QEM schema to repo
3 participants
@ecarlander @natestemen @cosenal